Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add take and drop functions #37

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Add take and drop functions #37

merged 2 commits into from
Oct 11, 2018

Conversation

remo5000
Copy link
Contributor

Features

  • Added take and drop for list library on request, as this is used for a mission

indocomsoft
indocomsoft approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@indocomsoft indocomsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 143

  • 2 of 8 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 33.04%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/list.js 2 8 25.0%
Totals Coverage Status
Change from base Build 123: -0.1%
Covered Lines: 967
Relevant Lines: 2795
💛 - Coveralls

@remo5000 remo5000 merged commit ace996e into master Oct 11, 2018
@geshuming geshuming deleted the take-drop branch June 10, 2019 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indocomsoft indocomsoft indocomsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@remo5000 @coveralls @indocomsoft